get rid of eval (use readarray)

2026-07-09 18:17:53 +02:00
parent c1ea14e145
commit 99dc9a4ef5
15 changed files with 130 additions and 46 deletions
--- a/profile.d/updates.sh
+++ b/profile.d/updates.sh
@@ -59,7 +59,9 @@ check_updates()
        disp E "Invalid options, use \"check_updates --help\" to display usage."
        return 2
    fi
-    eval set -- "$PARSED"
+    local -a _pargs=()
+    readarray -td '' _pargs < <(printf '%s' "$PARSED" | xargs printf '%s\0')
+    set -- "${_pargs[@]}"

    while true; do
        case "$1" in
@@ -139,7 +141,9 @@ profile_upgrade()
        disp E "Invalid options, use \"profile_upgrade --help\" to display usage."
        return 2
    fi
-    eval set -- "$PARSED"
+    local -a _pargs=()
+    readarray -td '' _pargs < <(printf '%s' "$PARSED" | xargs printf '%s\0')
+    set -- "${_pargs[@]}"
    while true; do
        case "$1" in
            -h|--help)