bugfix, esthetic cleanup, better comments, version bump

profile.d/compress.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -170,7 +171,7 @@ taz ()
             local procopt=""
             [[ $2 -gt 1 ]] &&
                 disp W "lzip doesn't support multithreading, falling back to 1 thread." &&
-                disp W "Consitder installing plzip to obtain multithreading abilities."
+                disp W "Consider installing plzip to obtain multithreading abilities."
         }
 
         [[ $4 ]] && local verb="-vv"
@@ -359,3 +360,6 @@ taz ()
     unset QUIET
 }
 export -f taz
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/debug.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -63,7 +64,6 @@ function error ()
     return $errcode
 }
 
-
 # ------------------------------------------------------------------------------
 # Activate or deactivate error trapping to display backtrace
 # ------------------------------------------------------------------------------
@@ -105,3 +105,6 @@ settrace ()
     unset status
 }
 export -f settrace
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/disp.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -111,7 +112,6 @@ export On_IPurple='\e[0;105m'
 export On_ICyan='\e[0;106m'
 export On_IWhite='\e[0;107m'
 
-
 # ------------------------------------------------------------------------------
 # Display a message
 # ------------------------------------------------------------------------------
@@ -146,3 +146,6 @@ disp()
     unset heads
 }
 export -f disp
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/filefct.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -47,7 +48,6 @@ expandlist()
     echo $result
 }
 
-
 # ------------------------------------------------------------------------------
 # Clean a directory or a tree from temporary or backup files
 # ------------------------------------------------------------------------------
@@ -100,7 +100,7 @@ clean ()
     unset recursive force
 
     for dir in $dirlist; do
-        local dellist=$(find $dir $findopt -type f -name "*~" -o -name "#*#" \
+        local dellist=$(find "$dir" $findopt -type f -name "*~" -o -name "#*#" \
             -o -name "*.bak" -o -name ".~*#")
         for f in $dellist; do
             if [[ ! $outshell ]]; then
@@ -114,7 +114,6 @@ clean ()
 }
 export -f clean
 
-
 # ------------------------------------------------------------------------------
 # Create a directory then goes inside
 # ------------------------------------------------------------------------------
@@ -125,11 +124,10 @@ mcd ()
         disp E "Usage: mcd <directory>"
         return 1
     fi
-    mkdir -pv $1 && cd $1
+    mkdir -pv "$1" && cd "$1" || echo "Failed create or change directory."
 }
 export -f mcd
 
-
 # ------------------------------------------------------------------------------
 # Rename all files in current directory to replace spaces with _
 # ------------------------------------------------------------------------------
@@ -212,3 +210,6 @@ rmspc ()
     unset lst substchar verb shell newf command mvopt
 }
 export -f rmspc
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/fun.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -46,3 +47,6 @@ busy()
     cat /dev/urandom | hexdump -C | grep "$pattern"
     unset pattern
 }
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/help.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -66,3 +67,5 @@ EOF
 }
 export -f help
 
+# ------------------------------------------------------------------------------
+# EOF

profile.d/info.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -42,7 +43,6 @@ ver ()
 }
 export -f ver
 
-
 # ------------------------------------------------------------------------------
 # Display weather of the given city (or default one)
 # ------------------------------------------------------------------------------
@@ -57,7 +57,6 @@ meteo ()
 }
 export -f meteo
 
-
 # ------------------------------------------------------------------------------
 # Display system general information
 # ------------------------------------------------------------------------------
@@ -88,3 +87,6 @@ showinfo()
     fi
 }
 export -f showinfo
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/lang.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -68,3 +69,6 @@ setus ()
     export LC_ALL=en_US.UTF-8
 }
 export -f setus
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/net.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -47,8 +48,8 @@ isipv4 ()
         IFS="."
         ip=($ip)
         IFS=$old_ifs
-	if [[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \
+        if [[ ${ip[0]} -le 255 && ${ip[1]} -le 255 &&
-		  && ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]; then
+            ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]; then
             if [[ -t 1 ]]; then
                 disp "The given IPv4 is valid."
             fi
@@ -62,7 +63,6 @@ isipv4 ()
 }
 export -f isipv4
 
-
 # ------------------------------------------------------------------------------
 # Determine if parameter is a valid IPv4 address
 # ------------------------------------------------------------------------------
@@ -82,3 +82,6 @@ isipv6 ()
     return 1
 }
 export -f isipv6
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/packages.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -77,3 +78,6 @@ pkgs ()
     $cmd | grep $pkg
 }
 export -f pkgs
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/processes.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -38,11 +39,10 @@
 # ------------------------------------------------------------------------------
 ppg()
 {
-    ps -edf | grep $@ | grep -v "grep $@"
+    ps -edf | grep "$@" | grep -v "grep $@"
 }
 export -f ppg
 
-
 # ------------------------------------------------------------------------------
 # Get PID list of the given process name
 # ------------------------------------------------------------------------------
@@ -62,14 +62,33 @@ gpid ()
 }
 export -f gpid
 
-
 # ------------------------------------------------------------------------------
 # Kill all processes owned by the given users
 # ------------------------------------------------------------------------------
 ku()
 {
     for u in $@; do
-        killall -u $u
+        killall -u "$u"
     done
 }
 export -f ku
+
+# ------------------------------------------------------------------------------
+# Kill all children of a process then the process
+# ------------------------------------------------------------------------------
+kt()
+{
+    [[ -z $1 ]] && echo -e "Usage:\n\tkt <pid> [kill_options]"
+
+    local parent_pid="$1" children_pids
+    shift
+    children_pids=$(pgrep -P "$parent_pid")
+
+    for pid in $children_pids; do
+        kill_tree "$pid" "$@"
+    done
+    kill "$@" "$parent_pid"
+}
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/prompt.sh

@@ -123,3 +123,6 @@ set_prompt ()
     # the text color to the default.
     PS1+="$ICyan\\w \\\$$Default "
 }
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/pwd.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -120,12 +121,11 @@ genpwd()
     done
 
     # Function selecting a random caracter from the list in parameter
-    pickcar()
+    pickcar() {
-    {
         # When a character is picked we check if it's not appearing already twice
         # elsewhere, we choose an other char, to compensate weak bash randomizer
         while [[ -z $char ]]; do
-	    local char=$(echo ${1:RANDOM%${#1}:1} $RANDOM)
+            local char="${1:RANDOM%${#1}:1} $RANDOM"
             if [[ $(awk -F"$char" '{print NF-1}' <<<"$picked") -gt $occurs ]]; then
                 unset char
             fi
@@ -184,3 +184,6 @@ genpwd()
     done
 }
 export -f genpwd
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/rain.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -54,7 +55,6 @@ rain()
     local X=0 Y=0 drop_length=0 rain_drop=0
     local max_rain_width=0 new_rain_odd=0 falling_odd=0
 
-
     sigwinch() {
         term_width=$(tput cols)
         term_height=$(tput lines)
@@ -152,3 +152,6 @@ rain()
     trap - WINCH
 }
 export -f rain
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/ssh.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -77,7 +78,6 @@ rmhost ()
 }
 export -f rmhost
 
-
 # ------------------------------------------------------------------------------
 # Login root via SSH on the given machine
 # ------------------------------------------------------------------------------
@@ -103,3 +103,6 @@ ssr ()
     ssh -Y root@$srv $@
 }
 export -f ssr
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/updates.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -33,24 +34,69 @@
 # * OF SUCH DAMAGE.
 # ------------------------------------------------------------------------------
 
+export UPDT_URL="https://git.geoffray-levasseur.org/fatalerrors/profile/raw/branch/master"
+
 # ------------------------------------------------------------------------------
 # Check for profile updates
 # ------------------------------------------------------------------------------
 check_updates()
 {
+    if [[ $1 == "-q" ]]; then
+        # Quiet mode is mostly used internally when profile_upgrade is called
+        quiet=1
+    fi
     disp I "Checking for updates..."
     local vfile="/tmp/version"
-    wget "$UPDT_URL/version" -O $vfile 2&>1 /dev/null || {
+    wget "$UPDT_URL/version" -O $vfile >/dev/null 2>&1 || {
-	disp E "Can\'t download information file, impossible to proceed!"
+        disp E "Can't download version file, impossible to proceed!"
-	return 1
+        return 5
     }
+
     if [[ -s /tmp/version ]]; then
         local lastver=$(cat /tmp/version)
         if [[ $lastver != $PROFVERSION ]]; then
             disp I "You have version $PROFVERSION installed. Version $lastver is available."
-	    disp I "You should upgrade to last version when possible."
+            [[ $quiet ]] && disp I "You should upgrade to last version when possible."
+            result=0
+        else
+            disp I "Your version is up-to-date."
+            result=1
         fi
+        rm -f $vfile
     else
         disp E "Impossible to read temporary file, impossible to proceed."
     fi
+    unset lastver vfile
+    return $result
 }
+
+# ------------------------------------------------------------------------------
+# Apply update to profile
+# ------------------------------------------------------------------------------
+profile_upgrade()
+{
+    if [[ $(check_updates -q) -eq 0 ]]; then
+        if [[ -s $MYPATH/profile.sh ]]; then
+            disp E "Installation path detection failed, cannot upgrade automatically."
+            return 1
+        fi
+        if [[ -d $MYPATH/.git ]]; then
+            disp I "Git installation detected, applying git pull."
+            local curdir=$(pwd)
+            cd $MYPATH
+            git pull
+            if [[ $? -ne 0 ]]; then
+                disp E "Git pull failed, upgrade not applyed."
+            else
+                disp I "Successfully upgraded using git."
+                disp I "You should now logout and login again to enjoy new profile."
+                cd $curdir
+            fi
+        else
+            disp I "Applying traditionnal upgrade..."
+            # TODO
+        fi
+    fi
+}
+
+# EOF

profile.sh

@@ -35,7 +35,7 @@
 # * OF SUCH DAMAGE.
 # ------------------------------------------------------------------------------
 
-if [[ ! $(echo $SHELL | grep bash) ]]; then
+if [[ ! $SHELL =~ bash|zsh ]]; then
     echo "That environmet script is designed to be used with bash or zsh being the shell."
     echo "Please consider using bash or zsh instead, or patch me ;)!"
     return 1
@@ -72,7 +72,6 @@ pathappend ()
     export $pathvar="${!pathvar:+${!pathvar}:}$1"
 }
 
-
 # ------------------------------------------------------------------------------
 # ------------------------------------------------------------------------------
 # ********************************** MAIN PROGRAM ******************************
@@ -80,9 +79,13 @@ pathappend ()
 # ------------------------------------------------------------------------------
 
 # Store script's path (realpath -s resolve symlinks if profile.sh is a symlink)
+if [[ -z $PROFILE_PATH ]]; then
     export MYPATH=$(dirname $(realpath -s $0))
+else
+    export MYPATH=$PROFILE_PATH
+fi
 if [[ ! -e $MYPATH/profile.sh ]]; then
-    echo "[ Warning ] Path detection failed, using pwd..."
+    echo "[ Warning ] Path detection failed, trying to use pwd..."
     MYPATH=$(pwd)
     if [[ ! -e $MYPATH/profile.sh ]]; then
         echo "[ Error ] Impossible to determine installation path, pretty much nothing will work."
@@ -102,6 +105,10 @@ fi
 [[ -d ~/bin ]] && pathappend ~/bin
 [[ -d ~/.local/bin ]] && pathappend ~/.local/bin
 
+# ------------------------------------------------------------------------------
+# Default values are set here and will be overloaded with config file if any
+# ------------------------------------------------------------------------------
+
 # Set bash history
 export HISTSIZE=50000
 export HISTIGNORE="&:[bf]g:exit"
@@ -125,14 +132,14 @@ export DEFAULT_CITY="Toulouse"
 # ------------------------------------------------------------------------------
 
 # Load global configuration
-[[ -f $MYPATH/etc/profile.conf ]] && . ~/.profile.conf
+[[ -f $MYPATH/etc/profile.conf ]] && . $MYPATH/etc/profile.conf
 
 # Load personal configuration
 [[ -f ~/.profile.conf ]] && . ~/.profile.conf
 
 # Load module scripts
 for script in $MYPATH/profile.d/*.sh; do
-    if [ -r $script ] ; then
+    if [[ -r $script ]]; then
         . $script
     fi
 done

version

@@ -1 +1 @@
-3.3.1
+3.3.2