bugfix, esthetic cleanup, better comments, version bump

profile.d/compress.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -38,9 +39,9 @@
 # ------------------------------------------------------------------------------
 utaz()
 {
-    for opt in $@ ; do
+    for opt in $@; do
         case $opt in
-            "-h"|"--help")
+        "-h" | "--help")
             echo "utaz: uncompress all the given files and/or the ones found in the given"
             echo "      directories creating an host directory where needed."
             echo
@@ -55,15 +56,15 @@ utaz()
             return 0
             ;;
 
-            "-d"|"--delete")
+        "-d" | "--delete")
             local willrm=1
             ;;
 
-            "-c"|"--create-dir")
+        "-c" | "--create-dir")
             local createdir=1
             ;;
 
-            "-n"|"--no-dir")
+        "-n" | "--no-dir")
             local nodir=1
             ;;
 
@@ -85,7 +86,7 @@ utaz()
     [[ ! $LIST ]] && local LIST="."
 
     for zitem in $LIST; do
-        [[ $(ls $zitem/*.zip 2> /dev/null | wc -l) -eq 0 ]] &&
+        [[ $(ls $zitem/*.zip 2>/dev/null | wc -l) -eq 0 ]] &&
             disp W "$zitem contains no supported archive file, skipping." &&
             continue
 
@@ -98,7 +99,7 @@ utaz()
                 disp E "The filesystem can't create directories, exit!" &&
                 return 1
 
-            unzip -o $f -d $dir > /dev/null 2>&1
+            unzip -o $f -d $dir >/dev/null 2>&1
             case $? in
             0)
                 [[ $willrm ]] && rm -f $f && disp I "File $zitem/$f deleted."
@@ -109,7 +110,7 @@ utaz()
                 ;;
             *)
                 disp E "The zip file seems corrupted, failed."
-                    rm -rf $dir > /dev/null 2>&1
+                rm -rf $dir >/dev/null 2>&1
                 continue
                 ;;
             esac
@@ -136,7 +137,7 @@ export -f utaz
 # ------------------------------------------------------------------------------
 # Compress directories or files into one or more archive
 # ------------------------------------------------------------------------------
-taz ()
+taz()
 {
     _doxz()
     {
@@ -170,7 +171,7 @@ taz ()
             local procopt=""
             [[ $2 -gt 1 ]] &&
                 disp W "lzip doesn't support multithreading, falling back to 1 thread." &&
-                disp W "Consitder installing plzip to obtain multithreading abilities."
+                disp W "Consider installing plzip to obtain multithreading abilities."
         }
 
         [[ $4 ]] && local verb="-vv"
@@ -243,9 +244,9 @@ taz ()
         return $?
     }
 
-    for opt in $@ ; do
+    for opt in $@; do
         case $opt in
-            "-h"|"--help")
+        "-h" | "--help")
             echo "taz: archive all files of a directory."
             echo
             echo "Usage: taz [option] [--parallel=<n>] [--format=<format>] [directory1 ... directoryN]"
@@ -273,23 +274,23 @@ taz ()
             return 0
             ;;
 
-            "-d"|"--delete")
+        "-d" | "--delete")
             local willrm=1
             ;;
 
-            "-f"?*|"--format"?*)
+        "-f"?* | "--format"?*)
             local compform=$(echo "$opt" | cut -f 2- -d '=')
             ;;
 
-            "-p"?*|"--parallel"?*)
+        "-p"?* | "--parallel"?*)
             local nproc=$(echo "$opt" | cut -f 2- -d '=')
             ;;
 
-            "-v"|"--verbose")
+        "-v" | "--verbose")
             local verbose=1
             ;;
 
-	    "-q"|"--quiet")
+        "-q" | "--quiet")
             QUIET=1
             ;;
 
@@ -359,3 +360,6 @@ taz ()
     unset QUIET
 }
 export -f taz
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/debug.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -36,7 +37,7 @@
 # ------------------------------------------------------------------------------
 # Display a backtrace
 # ------------------------------------------------------------------------------
-function backtrace ()
+function backtrace()
 {
     echo "========= Call stack ========="
     typeset -i i=0
@@ -45,7 +46,7 @@ function backtrace ()
     for func in "${FUNCNAME[@]}"; do
         if [[ $i -ne 0 ]]; then
             printf '%15s() %s:%d\n' \
-                   "$func" "${BASH_SOURCE[$i]}" "${BASH_LINENO[ (( $i - 1)) ]}"
+                "$func" "${BASH_SOURCE[$i]}" "${BASH_LINENO[(($i - 1))]}"
         fi
         let i++ || true
     done
@@ -56,25 +57,24 @@ function backtrace ()
 # ------------------------------------------------------------------------------
 # Function to be trapped for errors investigation
 # ------------------------------------------------------------------------------
-function error ()
+function error()
 {
     local errcode=$?
     backtrace
     return $errcode
 }
 
-
 # ------------------------------------------------------------------------------
 # Activate or deactivate error trapping to display backtrace
 # ------------------------------------------------------------------------------
-settrace ()
+settrace()
 {
     local status="off"
     [[ $(trap -p ERR) ]] && status="on"
     #trap -p ERR
-    for opt in $@ ; do
+    for opt in $@; do
         case $opt in
-            "-h"|"--help")
+        "-h" | "--help")
             echo "Try to activate backtrace display for script debugging."
             echo
             echo "Options:"
@@ -105,3 +105,6 @@ settrace ()
     unset status
 }
 export -f settrace
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/disp.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -111,7 +112,6 @@ export On_IPurple='\e[0;105m'
 export On_ICyan='\e[0;106m'
 export On_IWhite='\e[0;107m'
 
-
 # ------------------------------------------------------------------------------
 # Display a message
 # ------------------------------------------------------------------------------
@@ -146,3 +146,6 @@ disp()
     unset heads
 }
 export -f disp
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/filefct.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -47,19 +48,18 @@ expandlist()
     echo $result
 }
 
-
 # ------------------------------------------------------------------------------
 # Clean a directory or a tree from temporary or backup files
 # ------------------------------------------------------------------------------
-clean ()
+clean()
 {
-    for opt in $@ ; do
+    for opt in $@; do
         case $opt in
-            "-r"|"--recurs")
+        "-r" | "--recurs")
             local recursive=1
             ;;
 
-            "-h"|"--help")
+        "-h" | "--help")
             echo "clean: erase backup files in the given directories."
             echo
             echo "Usage: clean [option] [directory1] [...[directoryX]]"
@@ -73,11 +73,11 @@ clean ()
             return 0
             ;;
 
-            "-s"|"--shell")
+        "-s" | "--shell")
             local outshell=1
             ;;
 
-            "-f"|"--force")
+        "-f" | "--force")
             local force=1
             ;;
 
@@ -100,7 +100,7 @@ clean ()
     unset recursive force
 
     for dir in $dirlist; do
-        local dellist=$(find $dir $findopt -type f -name "*~" -o -name "#*#" \
+        local dellist=$(find "$dir" $findopt -type f -name "*~" -o -name "#*#" \
             -o -name "*.bak" -o -name ".~*#")
         for f in $dellist; do
             if [[ ! $outshell ]]; then
@@ -114,31 +114,29 @@ clean ()
 }
 export -f clean
 
-
 # ------------------------------------------------------------------------------
 # Create a directory then goes inside
 # ------------------------------------------------------------------------------
-mcd ()
+mcd()
 {
-    if [[ ! $# -eq 1 ]] ; then
+    if [[ ! $# -eq 1 ]]; then
         disp E "Create a directory then goes inside."
         disp E "Usage: mcd <directory>"
         return 1
     fi
-    mkdir -pv $1 && cd $1
+    mkdir -pv "$1" && cd "$1" || echo "Failed create or change directory."
 }
 export -f mcd
 
-
 # ------------------------------------------------------------------------------
 # Rename all files in current directory to replace spaces with _
 # ------------------------------------------------------------------------------
-rmspc ()
+rmspc()
 {
     local lst=""
-    for opt in $@ ; do
+    for opt in $@; do
         case $opt in
-            "-h"|"--help")
+        "-h" | "--help")
             echo "rmspc: remove spaces from all filenames in current directories"
             echo
             echo "Usage: rmspc [option]"
@@ -156,11 +154,11 @@ rmspc ()
             return 0
             ;;
 
-            "-r"|"--recursive")
+        "-r" | "--recursive")
             local recurs=1
             ;;
 
-            "-c"?*|"--subst-char"?*)
+        "-c"?* | "--subst-char"?*)
             if [[ $(echo $opt | grep "=") ]]; then
                 local substchar=$(echo "$opt" | cut -f 2- -d '=')
             else
@@ -168,11 +166,11 @@ rmspc ()
             fi
             ;;
 
-	    "-v"|"--verbose")
+        "-v" | "--verbose")
             local verb=1
             ;;
 
-            "-s"|"--shell")
+        "-s" | "--shell")
             local shell=1
             ;;
 
@@ -192,9 +190,9 @@ rmspc ()
         [[ $recurs ]] && [[ -d "$f" ]] && (
             [[ $verb ]] && disp I "Entering directory $(pwd)/$f ..."
             local lastdir=$f
-            pushd "$f" > /dev/null
+            pushd "$f" >/dev/null
             rmspc $@
-            popd > /dev/null
+            popd >/dev/null
             [[ $verb ]] && disp I "Leaving directory $(pwd)/$lastdir"
             unset lastdir
         )
@@ -212,3 +210,6 @@ rmspc ()
     unset lst substchar verb shell newf command mvopt
 }
 export -f rmspc
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/fun.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -46,3 +47,6 @@ busy()
     cat /dev/urandom | hexdump -C | grep "$pattern"
     unset pattern
 }
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/help.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -66,3 +67,5 @@ EOF
 }
 export -f help
 
+# ------------------------------------------------------------------------------
+# EOF

profile.d/info.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -36,17 +37,16 @@
 # ------------------------------------------------------------------------------
 # Show profile version
 # ------------------------------------------------------------------------------
-ver ()
+ver()
 {
     disp "Profile version $PROFVERSION."
 }
 export -f ver
 
-
 # ------------------------------------------------------------------------------
 # Display weather of the given city (or default one)
 # ------------------------------------------------------------------------------
-meteo ()
+meteo()
 {
     cities=$@
     [[ $# -eq 0 ]] && local cities=$DEFAULT_CITY
@@ -57,7 +57,6 @@ meteo ()
 }
 export -f meteo
 
-
 # ------------------------------------------------------------------------------
 # Display system general information
 # ------------------------------------------------------------------------------
@@ -88,3 +87,6 @@ showinfo()
     fi
 }
 export -f showinfo
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/lang.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -36,7 +37,7 @@
 # ------------------------------------------------------------------------------
 # Change locale to French
 # ------------------------------------------------------------------------------
-setfr ()
+setfr()
 {
     # Set fr locale definitions
     export LANG=fr_FR.UTF-8
@@ -48,7 +49,7 @@ export -f setfr
 # ------------------------------------------------------------------------------
 # Change locale to C standard
 # ------------------------------------------------------------------------------
-setc ()
+setc()
 {
     # Locale definitions
     export LANG=C
@@ -60,7 +61,7 @@ export -f setc
 # ------------------------------------------------------------------------------
 # Change locale to US (needed by Steam)
 # ------------------------------------------------------------------------------
-setus ()
+setus()
 {
     # Locale definitions
     export LANG=en_US.UTF-8
@@ -68,3 +69,6 @@ setus ()
     export LC_ALL=en_US.UTF-8
 }
 export -f setus
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/net.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -36,7 +37,7 @@
 # ------------------------------------------------------------------------------
 # Determine if parameter is a valid IPv4 address
 # ------------------------------------------------------------------------------
-isipv4 ()
+isipv4()
 {
     # Set up local variables
     local ip=$1
@@ -47,8 +48,8 @@ isipv4 ()
         IFS="."
         ip=($ip)
         IFS=$old_ifs
-	if [[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \
-		  && ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]; then
+        if [[ ${ip[0]} -le 255 && ${ip[1]} -le 255 &&
+            ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]; then
             if [[ -t 1 ]]; then
                 disp "The given IPv4 is valid."
             fi
@@ -62,11 +63,10 @@ isipv4 ()
 }
 export -f isipv4
 
-
 # ------------------------------------------------------------------------------
 # Determine if parameter is a valid IPv4 address
 # ------------------------------------------------------------------------------
-isipv6 ()
+isipv6()
 {
     local ip="$1"
     local regex='^([0-9a-fA-F]{0,4}:){1,7}[0-9a-fA-F]{0,4}$'
@@ -82,3 +82,6 @@ isipv6 ()
     return 1
 }
 export -f isipv6
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/packages.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -36,12 +37,12 @@
 # ------------------------------------------------------------------------------
 # Look for a package within installed one
 # ------------------------------------------------------------------------------
-pkgs ()
+pkgs()
 {
     local count=0
-    for opt in $@ ; do
+    for opt in $@; do
         case $opt in
-            "-h"|"--help")
+        "-h" | "--help")
             echo "dpkgs: look for an installed package by it's name."
             echo
             echo "Usage: dpkgs <string>"
@@ -56,7 +57,7 @@ pkgs ()
 
         *)
             local pkg=$1 && shift
-                count=$(( $count + 1 ))
+            count=$(($count + 1))
             [[ $count -gt 1 ]] &&
                 disp E "Please specify a package name, without space, eventually partial." &&
                 return 1
@@ -77,3 +78,6 @@ pkgs ()
     $cmd | grep $pkg
 }
 export -f pkgs
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/processes.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -36,17 +37,16 @@
 # ------------------------------------------------------------------------------
 # Search processes matching the given string
 # ------------------------------------------------------------------------------
-ppg ()
+ppg()
 {
-    ps -edf | grep $@ | grep -v "grep $@"
+    ps -edf | grep "$@" | grep -v "grep $@"
 }
 export -f ppg
 
-
 # ------------------------------------------------------------------------------
 # Get PID list of the given process name
 # ------------------------------------------------------------------------------
-gpid ()
+gpid()
 {
     [[ $UID -eq 0 ]] && local psopt="-A"
     [[ $# -eq 1 ]] && local single=1
@@ -62,14 +62,33 @@ gpid ()
 }
 export -f gpid
 
-
 # ------------------------------------------------------------------------------
 # Kill all processes owned by the given users
 # ------------------------------------------------------------------------------
-ku ()
+ku()
 {
     for u in $@; do
-        killall -u $u
+        killall -u "$u"
     done
 }
 export -f ku
+
+# ------------------------------------------------------------------------------
+# Kill all children of a process then the process
+# ------------------------------------------------------------------------------
+kt()
+{
+    [[ -z $1 ]] && echo -e "Usage:\n\tkt <pid> [kill_options]"
+
+    local parent_pid="$1" children_pids
+    shift
+    children_pids=$(pgrep -P "$parent_pid")
+
+    for pid in $children_pids; do
+        kill_tree "$pid" "$@"
+    done
+    kill "$@" "$parent_pid"
+}
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/prompt.sh

@@ -76,7 +76,7 @@ function timer_stop
 # ------------------------------------------------------------------------------
 # Function triguered internaly by bash : defining prompt
 # ------------------------------------------------------------------------------
-set_prompt ()
+set_prompt()
 {
     Last_Command=$? # Must come first!
     Blue='\[\e[0;34m\]'
@@ -123,3 +123,6 @@ set_prompt ()
     # the text color to the default.
     PS1+="$ICyan\\w \\\$$Default "
 }
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/pwd.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -47,7 +48,7 @@ genpwd()
 
     for opt in $@; do
         case $opt in
-	    "-h"|"--help")
+        "-h" | "--help")
             echo "genpwd: generate one or more secure random password."
             echo
             echo "Usage: genpwd [options] [--extracars=<cars>] [--length=<n>] [nb_passwd]"
@@ -75,29 +76,29 @@ genpwd()
             echo
             return 0
             ;;
-	    "-s"|"--nosymbols")
+        "-s" | "--nosymbols")
             symb=0
             ;;
-	    "-n"|"--nonumbers")
+        "-n" | "--nonumbers")
             numb=0
             ;;
-	    "-u"|"--noup")
+        "-u" | "--noup")
             maj=0
             ;;
-	    "-l"|"--nolow")
+        "-l" | "--nolow")
             min=0
             ;;
-	    "-e"?*|"--extracars"?*)
+        "-e"?* | "--extracars"?*)
             local extcar=$(echo "$opt" | cut -f 2- -d '=')
             ;;
-	    "-L"?*|"--length"?*)
+        "-L"?* | "--length"?*)
             local length=$(echo "$opt" | cut -f 2- -d '=')
             if ! [[ $length =~ ^[0-9]+$ ]]; then
                 disp E "The --length parameter requires a number."
                 return 1
             fi
             ;;
-	    "-o"?*|"--occurences"?*)
+        "-o"?* | "--occurences"?*)
             local occurs=$(echo "$opt" | cut -f 2- -d '=')
             if ! [[ $occurs =~ ^[1-9]+$ ]]; then
                 disp E "The --occurs parameter requires a number from 1 to 9."
@@ -120,13 +121,12 @@ genpwd()
     done
 
     # Function selecting a random caracter from the list in parameter
-    pickcar()
-    {
+    pickcar() {
         # When a character is picked we check if it's not appearing already twice
         # elsewhere, we choose an other char, to compensate weak bash randomizer
         while [[ -z $char ]]; do
-	    local char=$(echo ${1:RANDOM%${#1}:1} $RANDOM)
-	    if [[ $(awk -F"$char" '{print NF-1}' <<< "$picked") -gt $occurs ]]; then
+            local char="${1:RANDOM%${#1}:1} $RANDOM"
+            if [[ $(awk -F"$char" '{print NF-1}' <<<"$picked") -gt $occurs ]]; then
                 unset char
             fi
         done
@@ -135,7 +135,7 @@ genpwd()
     }
 
     disp I "Generating $nbpwd passwords, please wait..."
-    for n in $( seq 1 $nbpwd ); do
+    for n in $(seq 1 $nbpwd); do
         {
             local carset='' # store final caracter set to use
             local picked='' # store already used caracter
@@ -145,27 +145,27 @@ genpwd()
             if [[ $symb == 1 ]]; then
                 pickcar '!.@#&%/^-_'
                 carset+='!.@#&%/^-_'
-		(( rlength++ ))
+                ((rlength++))
             fi
             if [[ $numb == 1 ]]; then
                 pickcar '0123456789'
                 carset+='0123456789'
-		(( rlength++ ))
+                ((rlength++))
             fi
             if [[ $maj == 1 ]]; then
                 pickcar 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'
                 carset+='ABCDEFGHIJKLMNOPQRSTUVWXYZ'
-		(( rlength++ ))
+                ((rlength++))
             fi
             if [[ $min == 1 ]]; then
                 pickcar 'abcdefghijklmnopqrstuvwxyz'
                 carset+='abcdefghijklmnopqrstuvwxyz'
-		(( rlength++ ))
+                ((rlength++))
             fi
             if [[ -n $extcar ]]; then
                 pickcar "$extcar"
                 carset+=$extcar
-		(( rlength++ ))
+                ((rlength++))
             fi
 
             # Check if we have enough car to have something viable
@@ -175,7 +175,7 @@ genpwd()
                 return 1
             fi
 
-	    for i in $( seq 1 $(( $length - $rlength )) ); do
+            for i in $(seq 1 $(($length - $rlength))); do
                 pickcar "$carset"
             done
         } | sort -R | awk '{printf "%s", $1}'
@@ -184,3 +184,6 @@ genpwd()
     done
 }
 export -f genpwd
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/rain.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -43,7 +44,7 @@ rain()
     local rain_colors=("\e[37m" "\e[37;1m")
     # More from 256 color mode
     for i in {244..255}; do
-        rain_colors=( "${rain_colors[@]}" "\e[38;5;${i}m" )
+        rain_colors=("${rain_colors[@]}" "\e[38;5;${i}m")
     done
     local rain_tab=${#rain_cars[@]}
     local rain_color_tab=${#rain_colors[@]}
@@ -54,18 +55,17 @@ rain()
     local X=0 Y=0 drop_length=0 rain_drop=0
     local max_rain_width=0 new_rain_odd=0 falling_odd=0
 
-
     sigwinch() {
         term_width=$(tput cols)
         term_height=$(tput lines)
         #step_duration=0.025
-        (( max_rain_width = term_width * term_height / 4 ))
-        (( max_rain_height = term_height < 10 ? 1 : term_height / 10 ))
+        ((max_rain_width = term_width * term_height / 4))
+        ((max_rain_height = term_height < 10 ? 1 : term_height / 10))
         # In percentage
-        (( new_rain_odd = term_height > 50 ? 100 : term_height * 2 ))
-        (( new_rain_odd = new_rain_odd * 75 / 100 ))
-        (( falling_odd = term_height > 25 ? 100 : term_height * 4 ))
-        (( falling_odd = falling_odd * 90 / 100 ))
+        ((new_rain_odd = term_height > 50 ? 100 : term_height * 2))
+        ((new_rain_odd = new_rain_odd * 75 / 100))
+        ((falling_odd = term_height > 25 ? 100 : term_height * 4))
+        ((falling_odd = falling_odd * 90 / 100))
     }
 
     do_exit() {
@@ -80,19 +80,19 @@ rain()
             Y=${rains[idx + 1]}
             drop_length=${rains[idx + 4]}
             for ((y = Y; y < Y + drop_length; y++)); do
-                (( y < 1 || y > term_height )) && continue
+                ((y < 1 || y > term_height)) && continue
                 echo -ne "\e[${y};${X}H "
             done
         done
 
         for ((idx = 0; idx < num_rains * num_rain_metadata; idx += num_rain_metadata)); do
-            if (( 100 * RANDOM / 32768 < falling_odd )); then
+            if ((100 * RANDOM / 32768 < falling_odd)); then
                 # Falling
-                if (( ++rains[idx + 1] > term_height )); then
+                if ((++rains[idx + 1] > term_height)); then
                     # Out of screen, bye sweet <3
                     rains=("${rains[@]:0:idx}"
                         "${rains[@]:idx+num_rain_metadata:num_rains*num_rain_metadata}")
-                    (( num_rains-- ))
+                    ((num_rains--))
                     continue
                 fi
             fi
@@ -102,7 +102,7 @@ rain()
             drop_color=${rains[idx + 3]}
             drop_length=${rains[idx + 4]}
             for ((y = Y; y < Y + drop_length; y++)); do
-                (( y < 1 || y > term_height )) && continue
+                ((y < 1 || y > term_height)) && continue
                 echo -ne "\e[${y};${X}H${drop_color}${rain_drop}"
             done
         done
@@ -118,24 +118,24 @@ rain()
     local rains=()
     local num_rains=0
     sigwinch
-    while (( exit_st <= 0 )); do
-        if (( $exit_st <=0 )); then
+    while ((exit_st <= 0)); do
+        if (($exit_st <= 0)); then
             read -n 1 -t $step_duration ch
             case "$ch" in
-                q|Q)
+            q | Q)
                 do_exit
                 ;;
             esac
 
-            if (( num_rains < max_rain_width )) && (( 100 * RANDOM / 32768 < new_rain_odd )); then
+            if ((num_rains < max_rain_width)) && ((100 * RANDOM / 32768 < new_rain_odd)); then
                 # Need new |, 1-based
                 rain_drop="${rain_cars[rain_tab * RANDOM / 32768]}"
                 drop_color="${rain_colors[rain_color_tab * RANDOM / 32768]}"
-                drop_length=$(( max_rain_height * RANDOM / 32768 + 1 ))
-                X=$(( term_width * RANDOM / 32768 + 1 ))
-                Y=$(( 1 - drop_length ))
-                rains=( "${rains[@]}" "$X" "$Y" "$rain_drop" "$drop_color" "$drop_length" )
-                (( num_rains++ ))
+                drop_length=$((max_rain_height * RANDOM / 32768 + 1))
+                X=$((term_width * RANDOM / 32768 + 1))
+                Y=$((1 - drop_length))
+                rains=("${rains[@]}" "$X" "$Y" "$rain_drop" "$drop_color" "$drop_length")
+                ((num_rains++))
             fi
 
             # Let rain fall!
@@ -152,3 +152,6 @@ rain()
     trap - WINCH
 }
 export -f rain
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/ssh.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -36,7 +37,7 @@
 # ------------------------------------------------------------------------------
 # Remove host from know_host (name and IP) for the active user
 # ------------------------------------------------------------------------------
-rmhost ()
+rmhost()
 {
     if [[ "$#" -lt 1 ]]; then
         disp E "Incorrect number of parameters."
@@ -46,9 +47,9 @@ rmhost ()
 
     while [[ $1 ]]; do
         local hst=$1 && shift
-	isipv4 $hst > /dev/null
+        isipv4 $hst >/dev/null
         local v4=$?
-	isipv6 $hst > /dev/null
+        isipv6 $hst >/dev/null
         local v6=$?
 
         if [[ $v4 -eq 0 || $v6 -eq 0 ]]; then
@@ -66,26 +67,25 @@ rmhost ()
 
         if [[ $hst ]]; then
             disp I "Removing host $hst from ssh known_host..."
-	    ssh-keygen -R $hst > /dev/null
+            ssh-keygen -R $hst >/dev/null
         fi
         if [[ $ip ]]; then
             disp I "Removing IP $ip from ssh known_host..."
-	    ssh-keygen -R $ip > /dev/null
+            ssh-keygen -R $ip >/dev/null
         fi
         unset hst ip
     done
 }
 export -f rmhost
 
-
 # ------------------------------------------------------------------------------
 # Login root via SSH on the given machine
 # ------------------------------------------------------------------------------
-ssr ()
+ssr()
 {
-    for opt in $@ ; do
+    for opt in $@; do
         case $opt in
-            "-h"|"--help")
+        "-h" | "--help")
             echo "ssr: do a root user ssh login."
             echo
             echo "Usage: ssr <server [ssh options]>"
@@ -103,3 +103,6 @@ ssr ()
     ssh -Y root@$srv $@
 }
 export -f ssr
+
+# ------------------------------------------------------------------------------
+# EOF

profile.d/updates.sh

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # ------------------------------------------------------------------------------
 # Copyright (c) 2013-2022 Geoffray Levasseur <fatalerrors@geoffray-levasseur.org>
 # Protected by the BSD3 license. Please read bellow for details.
@@ -33,24 +34,69 @@
 # * OF SUCH DAMAGE.
 # ------------------------------------------------------------------------------
 
+export UPDT_URL="https://git.geoffray-levasseur.org/fatalerrors/profile/raw/branch/master"
+
 # ------------------------------------------------------------------------------
 # Check for profile updates
 # ------------------------------------------------------------------------------
 check_updates()
 {
+    if [[ $1 == "-q" ]]; then
+        # Quiet mode is mostly used internally when profile_upgrade is called
+        quiet=1
+    fi
     disp I "Checking for updates..."
     local vfile="/tmp/version"
-    wget "$UPDT_URL/version" -O $vfile 2&>1 /dev/null || {
-	disp E "Can\'t download information file, impossible to proceed!"
-	return 1
+    wget "$UPDT_URL/version" -O $vfile >/dev/null 2>&1 || {
+        disp E "Can't download version file, impossible to proceed!"
+        return 5
     }
+
     if [[ -s /tmp/version ]]; then
         local lastver=$(cat /tmp/version)
         if [[ $lastver != $PROFVERSION ]]; then
             disp I "You have version $PROFVERSION installed. Version $lastver is available."
-	    disp I "You should upgrade to last version when possible."
+            [[ $quiet ]] && disp I "You should upgrade to last version when possible."
+            result=0
+        else
+            disp I "Your version is up-to-date."
+            result=1
         fi
+        rm -f $vfile
     else
         disp E "Impossible to read temporary file, impossible to proceed."
     fi
+    unset lastver vfile
+    return $result
 }
+
+# ------------------------------------------------------------------------------
+# Apply update to profile
+# ------------------------------------------------------------------------------
+profile_upgrade()
+{
+    if [[ $(check_updates -q) -eq 0 ]]; then
+        if [[ -s $MYPATH/profile.sh ]]; then
+            disp E "Installation path detection failed, cannot upgrade automatically."
+            return 1
+        fi
+        if [[ -d $MYPATH/.git ]]; then
+            disp I "Git installation detected, applying git pull."
+            local curdir=$(pwd)
+            cd $MYPATH
+            git pull
+            if [[ $? -ne 0 ]]; then
+                disp E "Git pull failed, upgrade not applyed."
+            else
+                disp I "Successfully upgraded using git."
+                disp I "You should now logout and login again to enjoy new profile."
+                cd $curdir
+            fi
+        else
+            disp I "Applying traditionnal upgrade..."
+            # TODO
+        fi
+    fi
+}
+
+# EOF

profile.sh

@@ -35,7 +35,7 @@
 # * OF SUCH DAMAGE.
 # ------------------------------------------------------------------------------
 
-if [[ ! $(echo $SHELL | grep bash) ]]; then
+if [[ ! $SHELL =~ bash|zsh ]]; then
     echo "That environmet script is designed to be used with bash or zsh being the shell."
     echo "Please consider using bash or zsh instead, or patch me ;)!"
     return 1
@@ -44,35 +44,34 @@ fi
 # ------------------------------------------------------------------------------
 # path* : private functions for PATH variable management
 # ------------------------------------------------------------------------------
-pathremove ()
+pathremove()
 {
     local ifs=':'
     local newpath
     local dir
     local pathvar=${2:-PATH}
-    for dir in ${!pathvar} ; do
-        if [ "$dir" != "$1" ] ; then
+    for dir in ${!pathvar}; do
+        if [ "$dir" != "$1" ]; then
             newpath=${newpath:+$newpath:}$dir
         fi
     done
     export $pathvar="$newpath"
 }
 
-pathprepend ()
+pathprepend()
 {
     pathremove $1 $2
     local pathvar=${2:-PATH}
     export $pathvar="$1${!pathvar:+:${!pathvar}}"
 }
 
-pathappend ()
+pathappend()
 {
     pathremove $1 $2
     local pathvar=${2:-PATH}
     export $pathvar="${!pathvar:+${!pathvar}:}$1"
 }
 
-
 # ------------------------------------------------------------------------------
 # ------------------------------------------------------------------------------
 # ********************************** MAIN PROGRAM ******************************
@@ -80,9 +79,13 @@ pathappend ()
 # ------------------------------------------------------------------------------
 
 # Store script's path (realpath -s resolve symlinks if profile.sh is a symlink)
-export MYPATH=$(dirname $(realpath -s $0))
+if [[ -z $PROFILE_PATH ]]; then
+    export MYPATH=$(dirname $(realpath -s $0))
+else
+    export MYPATH=$PROFILE_PATH
+fi
 if [[ ! -e $MYPATH/profile.sh ]]; then
-    echo "[ Warning ] Path detection failed, using pwd..."
+    echo "[ Warning ] Path detection failed, trying to use pwd..."
     MYPATH=$(pwd)
     if [[ ! -e $MYPATH/profile.sh ]]; then
         echo "[ Error ] Impossible to determine installation path, pretty much nothing will work."
@@ -95,13 +98,17 @@ fi
 export PROFVERSION=$(cat $MYPATH/version)
 
 # Build PATH environment variable
-if [[ $EUID -eq 0 ]] ; then
+if [[ $EUID -eq 0 ]]; then
     pathappend /sbin:/usr/sbin
 fi
 [[ -d /share/services/gestparc ]] && pathappend /share/services/gestparc
 [[ -d ~/bin ]] && pathappend ~/bin
 [[ -d ~/.local/bin ]] && pathappend ~/.local/bin
 
+# ------------------------------------------------------------------------------
+# Default values are set here and will be overloaded with config file if any
+# ------------------------------------------------------------------------------
+
 # Set bash history
 export HISTSIZE=50000
 export HISTIGNORE="&:[bf]g:exit"
@@ -125,14 +132,14 @@ export DEFAULT_CITY="Toulouse"
 # ------------------------------------------------------------------------------
 
 # Load global configuration
-[[ -f $MYPATH/etc/profile.conf ]] && . ~/.profile.conf
+[[ -f $MYPATH/etc/profile.conf ]] && . $MYPATH/etc/profile.conf
 
 # Load personal configuration
 [[ -f ~/.profile.conf ]] && . ~/.profile.conf
 
 # Load module scripts
-for script in $MYPATH/profile.d/*.sh ; do
-    if [ -r $script ] ; then
+for script in $MYPATH/profile.d/*.sh; do
+    if [[ -r $script ]]; then
         . $script
     fi
 done

version

@@ -1 +1 @@
-3.3.1
+3.3.2